feat: octane-table adapter - #6477
Merged
Merged
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 946 files, which is 646 over the limit of 300. To get a review, narrow the scope: Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (946)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit aef2916
☁️ Nx Cloud last updated this comment at |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We updated knip.json to fix the table:test:knip failure introduced by the octane-table adapter PR. Adding docs-entry.d.ts! as an explicit entry point prevents knip from reporting it as an unused file, and removing the four redundant export patterns (src/index.ts!, src/static-functions.ts!, src/flex-render.ts!, src/experimental-worker-plugin.ts!) eliminates the configuration hint warnings since those paths are already auto-detected via the package's exports field.
Tip
✅ We verified this fix by re-running table:test:knip.
diff --git a/knip.json b/knip.json
index aab19bc8..160170d6 100644
--- a/knip.json
+++ b/knip.json
@@ -38,15 +38,12 @@
},
"packages/octane-table": {
"entry": [
- "src/index.ts!",
+ "docs-entry.d.ts!",
"src/Subscribe.tsrx!",
"src/createTableHook.tsrx!",
"src/useTable.tsrx!",
"src/internal.ts!",
"src/reactivity.ts!",
- "src/static-functions.ts!",
- "src/flex-render.ts!",
- "src/experimental-worker-plugin.ts!",
"tests/type-tests/public-surface.tsx!"
]
},
Or Apply changes locally with:
npx nx-cloud apply-locally gjXO-7DZO
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
AlemTuzlak
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
✅ Checklist
pnpm test:pr.