docs(svelte): replace deprecated isLoading with isPending in overview#11003
Open
poetryofcode wants to merge 1 commit into
Open
docs(svelte): replace deprecated isLoading with isPending in overview#11003poetryofcode wants to merge 1 commit into
poetryofcode wants to merge 1 commit into
Conversation
`isLoading` is a deprecated alias for `isPending && isFetching` and is scheduled for removal in the next major version. The overview example shows a standard (always-enabled) query, so `isPending` is the correct flag. All other framework overview docs (React, Vue, Angular, Lit, Preact) already use `isPending`. Note: `isLoading` is intentionally retained in disabling-queries guides where it is the right flag for disabled/lazy queries. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single-line change in the Svelte overview documentation updates the example's conditional rendering check from ChangesSvelte Docs Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Svelte overview example used
query.isLoadingwhich is a deprecated alias in TanStack Query v5. The correct property isquery.isPending.isPendingisLoadingwas deprecated in v5 and is now just an alias forisPending && isFetchingChanges
docs/framework/svelte/overview.md: Changed{#if query.isLoading}→{#if query.isPending}Test plan
isPendingmatches the API reference docsSummary by CodeRabbit