Repository navigation
ci(oracles): run the mutant-validity oracle in CI - #24
Merged
Merged
Conversation
CI runs `test:oracle-gaps:fast`, which named the static, classify, and probe-form oracles but not the mutant-validity oracle (#8). So CI never checked that every emitted mutant is detectable and every skipped one is not. The fast script now includes it. The four fast oracles take about 62 s locally at 2 workers (31,249 tests). Co-authored-by: Isaac <no-reply@databricks.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI now runs the mutant-validity oracle. Before this change, CI never checked that each mutant the gap CLI emits is detectable, and that each skipped one is not.
Why it matters
The CI workflow runs
pnpm --filter @tanstack/oracles run test:oracle-gaps:fast. That script named the static, classify, and probe-form oracles, but not the mutant-validity oracle from #8. A change to the emitter could skip a detectable mutant, or emit one that no input detects, and CI would stay green. A review of the held F11 work found the gap.What changes
test:oracle-gaps:fastnow also runsgap-report-mutant-validity.Evidence
Limits
CI still does not run the end-to-end gap oracle (
gap-report-oracle.property). It takes about 30 minutes, so authors run it locally with its fixed seed. Whether CI should run it is a separate decision for the maintainer.This pull request and its description were written by Isaac.