Skip to content

refactor: remove in-app feedback panel, link Help menu to GitHub Issues#1253

Merged
datlechin merged 1 commit into
mainfrom
refactor/remove-feedback-panel
May 13, 2026
Merged

refactor: remove in-app feedback panel, link Help menu to GitHub Issues#1253
datlechin merged 1 commit into
mainfrom
refactor/remove-feedback-panel

Conversation

@datlechin
Copy link
Copy Markdown
Member

Summary

  • Deletes the in-app Help > Report an Issue panel (FeedbackView, FeedbackViewModel, FeedbackAPIClient, FeedbackDiagnosticsCollector, FeedbackDraft, FeedbackWindowController — 916 LOC) along with its docs page and screenshots.
  • Replaces the menu item with a one-liner that opens https://github.com/TableProApp/TablePro/issues via NSWorkspace.shared.open. GitHub's bug/feature templates already cover what the in-app form did.
  • Drops 8 feedback-only localization keys (Bug Report, Feature Request, General Feedback, the network/server/rate-limit/too-large/unexpected-response error strings, and the "Report an Issue..." ellipsis label). Keeps the shared Report an Issue, Network error: %@, and Server error (%d): %@ keys used elsewhere.
  • The api.tablepro.app/v1/feedback server endpoint is no longer called by any client and can be retired separately.

Test plan

  • Build clean in Xcode (-skipPackagePluginValidation).
  • Launch app: Help menu shows Report an Issue (no ellipsis).
  • Click it: default browser opens https://github.com/TableProApp/TablePro/issues.
  • App launches with no console warnings about FeedbackAPIClient / FeedbackViewModel symbols.
  • swiftlint lint --strict passes.
  • grep -rn "Feedback" TablePro/ --include="*.swift" shows no feature symbols (only the unrelated draggingDestinationFeedbackStyle and copyQueryWithFeedback matches).

@datlechin datlechin merged commit da35976 into main May 13, 2026
2 checks passed
@datlechin datlechin deleted the refactor/remove-feedback-panel branch May 13, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant