refactor: remove in-app feedback panel, link Help menu to GitHub Issues#1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FeedbackView,FeedbackViewModel,FeedbackAPIClient,FeedbackDiagnosticsCollector,FeedbackDraft,FeedbackWindowController— 916 LOC) along with its docs page and screenshots.https://github.com/TableProApp/TablePro/issuesviaNSWorkspace.shared.open. GitHub's bug/feature templates already cover what the in-app form did.Report an Issue,Network error: %@, andServer error (%d): %@keys used elsewhere.api.tablepro.app/v1/feedbackserver endpoint is no longer called by any client and can be retired separately.Test plan
-skipPackagePluginValidation).Report an Issue(no ellipsis).https://github.com/TableProApp/TablePro/issues.FeedbackAPIClient/FeedbackViewModelsymbols.swiftlint lint --strictpasses.grep -rn "Feedback" TablePro/ --include="*.swift"shows no feature symbols (only the unrelateddraggingDestinationFeedbackStyleandcopyQueryWithFeedbackmatches).