Repository navigation
ArteCheck: move bottom rows when an MNR 11 header becomes MNR 23 - #311
Merged
Merged
Conversation
Reported by Triathlon-rally on SubtitleEdit/subtitleedit#15185: the header fix set MNR 11 -> 23 but left one-line subtitles on VP 11 and two-line subtitles on VP 10. These now move to 22 and 20. Higher rows (e.g. VP 1) stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback from Triathlon-rally on SubtitleEdit/subtitleedit#15185 (comment).
When the source EBU header has fewer than 23 rows (e.g. MNR 11), the header fix sets MNR 23, but the rows were left on the small page's scale. Now subtitles at the bottom of the source page move to the ARTE bottom rows:
"Bottom of the source page" means the last line of the subtitle reaches row MNR. These rows are left out of the whole-file one-row-too-high check. Two new tests; 95 pass.
🤖 Generated with Claude Code