Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-checkbox-radio-selectors.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@stackoverflow/stacks": patch
---

Fix checkbox and radio label selectors so the published CSS can be minified with Lightning CSS.
7 changes: 7 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,10 @@ updates:
schedule:
interval: "weekly"
versioning-strategy: increase
groups:
vite-major:
patterns:
- "vite"
- "@sveltejs/vite-plugin-svelte"
update-types:
- "major"
5,357 changes: 2,753 additions & 2,604 deletions package-lock.json

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@changesets/read": "^1.0.1",
"@eslint/js": "^10.0.1",
"@open-wc/testing": "^5.0.0",
"@remcovaes/web-test-runner-vite-plugin": "^1.4.0",
"@remcovaes/web-test-runner-vite-plugin": "^1.4.1",
"@rollup/plugin-commonjs": "^29.0.2",
"@rollup/plugin-replace": "^6.0.3",
"@stackoverflow/prettier-config": "^1.0.0",
Expand All @@ -35,10 +35,10 @@
"@storybook/addon-a11y": "^10.4.0",
"@storybook/addon-docs": "^10.6.0",
"@storybook/addon-links": "^10.5.7",
"@storybook/addon-svelte-csf": "^5.0.10",
"@storybook/addon-svelte-csf": "^5.1.5",
"@storybook/svelte-vite": "^10.5.0",
"@sveltejs/package": "^2.5.7",
"@sveltejs/vite-plugin-svelte": "^6.2.4",
"@sveltejs/vite-plugin-svelte": "^7.3.1",
"@testing-library/dom": "^10.4.1",
"@testing-library/svelte": "^5.3.1",
"@testing-library/user-event": "^14.6.1",
Expand Down Expand Up @@ -86,7 +86,7 @@
"ts-loader": "^9.6.2",
"typescript": "^6.0.3",
"typescript-eslint": "^8.70.1",
"vite": "^7.3.3",
"vite": "^8.3.1",
"vitest": "^4.1.11",
"webpack": "^5.109.2",
"webpack-cli": "^7.2.2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12858,10 +12858,10 @@ fieldset[disabled] .s-radio,
.s-radio:has(> input[disabled]) .s-label {
--_ch-label-fc: var(--black-300);
}
.s-checkbox:not(> input[disabled]):has(input:checked) .s-label,
.s-radio:not(> input[disabled]):has(input:checked) .s-label,
.s-checkbox:not(> input[disabled]):has(input:indeterminate) .s-label,
.s-radio:not(> input[disabled]):has(input:indeterminate) .s-label {
.s-checkbox:not(:has(> input[disabled])):has(input:checked) .s-label,
.s-radio:not(:has(> input[disabled])):has(input:checked) .s-label,
.s-checkbox:not(:has(> input[disabled])):has(input:indeterminate) .s-label,
.s-radio:not(:has(> input[disabled])):has(input:indeterminate) .s-label {
--_ch-label-fc: var(--black-600);
}
.s-checkbox:has(> .s-label .s-description),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
}
}

&:not(> input[disabled]) {
&:not(:has(> input[disabled])) {
&:has(input:checked),
&:has(input:indeterminate) {
.s-label {
Expand Down Expand Up @@ -240,4 +240,4 @@
--_ch-input-bg: var(--white);
}
}
}
}
4 changes: 2 additions & 2 deletions packages/stacks-docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
"@eslint/compat": "^2.1.1",
"@sveltejs/adapter-netlify": "^6.0.4",
"@sveltejs/kit": "^2.70.2",
"@sveltejs/vite-plugin-svelte": "^6.0.0",
"@sveltejs/vite-plugin-svelte": "^7.3.1",
"mdsvex": "^0.12.8",
"vite": "^7.3.3"
"vite": "^8.3.1"
},
"dependencies": {
"@stackoverflow/stacks-email": "1.0.0-beta.0",
Expand Down
6 changes: 3 additions & 3 deletions packages/stacks-docs/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import { dirname, resolve } from "path";
import { sveltekit } from "@sveltejs/kit/vite";
import { defineConfig } from "vite";

import pkgMain from "../stacks-classic/package.json";
import pkgEmail from "../stacks-email/package.json";
import pkgSvelte from "../stacks-svelte/package.json";
import pkgMain from "../stacks-classic/package.json" with { type: "json" };
import pkgEmail from "../stacks-email/package.json" with { type: "json" };
import pkgSvelte from "../stacks-svelte/package.json" with { type: "json" };

const __dirname = dirname(fileURLToPath(import.meta.url));

Expand Down
4 changes: 2 additions & 2 deletions packages/stacks-email/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"devDependencies": {
"@sveltejs/adapter-auto": "^6.1.0",
"@sveltejs/kit": "^2.70.2",
"@sveltejs/vite-plugin-svelte": "^6.2.1",
"@sveltejs/vite-plugin-svelte": "^7.3.1",
"@stackoverflow/stacks": "3.0.0",
"@stackoverflow/stacks-icons": "^7.0.0",
"@stackoverflow/stacks-svelte": "*",
Expand All @@ -53,7 +53,7 @@
"svelte-check": "^4.7.6",
"typescript": "^6.0.3",
"typescript-eslint": "^8.70.1",
"vite": "^7.3.3",
"vite": "^8.3.1",
"vitest": "^4.1.11"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/stacks-email/vite.package.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default defineConfig({
formats: ["es"],
fileName: (_format, entryName) => `${entryName}.js`,
},
rollupOptions: {
rolldownOptions: {
external: (id) =>
externalPackages.some(
(dependency) =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
const { Story } = defineMeta({
title: "Components/Navigation",
component: Navigation,
// @ts-expect-error: subcomponents is not typed correctly - see related issue https://github.com/storybookjs/storybook/issues/23170
subcomponents: { NavigationItem, NavigationGroup },
argTypes: {
class: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
const { Story } = defineMeta({
title: "Components/Notice",
component: Notice,
// @ts-expect-error: subcomponents is not typed correctly - see related issue https://github.com/storybookjs/storybook/issues/23170
subcomponents: { NoticeAction },
argTypes: {
variant: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
const { Story } = defineMeta({
title: "Components/Popover",
component: Popover,
// @ts-expect-error: subcomponents is not typed correctly - see related issue https://github.com/storybookjs/storybook/issues/23170
subcomponents: { PopoverReference, PopoverContent, PopoverCloseButton },
argTypes: {
placement: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@
title: "Components/PostSummary",
component: PostSummary,
subcomponents: {
// @ts-expect-error: subcomponents is not typed correctly - see related issue https://github.com/storybookjs/storybook/issues/23170
PostSummaryAnswer,
},
argTypes: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
title: "Components/Select",
component: Select,
subcomponents: {
// @ts-expect-error: subcomponents is not typed correctly - see related issue https://github.com/storybookjs/storybook/issues/23170
SelectItem,
},
argTypes: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,9 @@
title: "Components/UserCard",
component: UserCard,
subcomponents: {
// @ts-expect-error: subcomponents is not typed correctly - see related issue https://github.com/storybookjs/storybook/issues/23170
UserCardTime,
// @ts-expect-error: subcomponents is not typed correctly - see related issue https://github.com/storybookjs/storybook/issues/23170
UserCardBadge,
// @ts-expect-error: subcomponents is not typed correctly - see related issue https://github.com/storybookjs/storybook/issues/23170
UserCardBling,
// @ts-expect-error: subcomponents is not typed correctly - see related issue https://github.com/storybookjs/storybook/issues/23170
UserCardAdditionalBling,
},
argTypes: {
Expand Down
3 changes: 2 additions & 1 deletion packages/stacks-svelte/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ import path from "path";
export default defineConfig({
plugins: [svelte(svelteConfig), svelteTesting(), svelteInlineComponent()],
optimizeDeps: {
// Keep the test runner's root-relative virtual WebSocket import intact.
exclude: ["@web/test-runner-commands"],
//without the following explicit includes, test runs fail on the first run because these dependencies don't get pre-optimized properly
include: [
"@web/test-runner-commands",
"@floating-ui/dom",
"svelte-floating-ui",
"sinon",
Expand Down
2 changes: 1 addition & 1 deletion packages/stacks-utils/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export default defineConfig({
formats: ["es"],
},
minify: false,
rollupOptions: {
rolldownOptions: {
external: (id) =>
external.some((dep) => id === dep || id.startsWith(`${dep}/`)),
output: {
Expand Down
Loading