SCANPY-176 Avoid using POETRY_LINUX_TEMPLATE for Mend, formatting and documentation tasks#231
SCANPY-176 Avoid using POETRY_LINUX_TEMPLATE for Mend, formatting and documentation tasks#231
Conversation
ghislainpiot
force-pushed
the
SCANPY-176
branch
3 times, most recently
from
4ee7b71 to
719654f
Compare
ghislainpiot
changed the title
Seppli11
left a comment
Seppli11
left a comment
There was a problem hiding this comment.
As discussed, the script feels really complicated to me. To understand what the YAML for a task actually looks like, one has to keep a lot of references in mind. I wonder if the complexity could be reduced by consolidating different configs.
At least personally, I don't mind having a container with all the tools that are needed by most tasks, if that means that the config gets simpler. Of course, granted that it doesn't impact reliability or the time the built takes significantly.
ghislainpiot
force-pushed
the
SCANPY-176
branch
2 times, most recently
from
6172b46 to
bdd2305
Compare
… documentation tasks
|
|
Sending this for review again. I don't think spending too much time on this is worth it, we should think about dropping the ticket. |
Seppli11
left a comment
Seppli11
left a comment
There was a problem hiding this comment.
LGTM!
This way feels a bit less tangled and easier to review. Thx for the refactoring
| memory: 2G | ||
|
|
||
| win_vm_definition: &WINDOWS_VM_DEFINITION | ||
| env: |
There was a problem hiding this comment.
This is smart. I like that the JF_ALIAS is now defined by the platform of the instance
2 participants
SCANPY-176