SCANPY-178: The scanner should respect the SONAR_SCANNER_OPTS environment variable#219
Merged
SCANPY-178: The scanner should respect the SONAR_SCANNER_OPTS environment variable#219
Conversation
joke1196
force-pushed
the
SCANPY-178
branch
2 times, most recently
from
18505c8 to
a0cafd6
Compare
ghislainpiot
approved these changes
Jun 13, 2025
Contributor
ghislainpiot
left a comment
ghislainpiot
left a comment
There was a problem hiding this comment.
I left a suggestion, once you get the CI green LGTM
| deprecated: bool = False | ||
|
|
||
| deprecation_message: Optional[str] = None |
Contributor
There was a problem hiding this comment.
I think we can combine the boolean into the optional
| TOML_PATH: Key = "toml-path" | ||
|
|
||
| # ============ DEPRECATED ============== | ||
| SONAR_SCANNER_OPTS = "sonar.scanner.opts" |
Contributor
There was a problem hiding this comment.
Some have the Key typehint, some don't. Not sure if it is intentional
Contributor
Author
There was a problem hiding this comment.
I will add the type hint to the others
joke1196
force-pushed
the
SCANPY-178
branch
4 times, most recently
from
45aff4d to
96e1e8f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCANPY-178
Part of