SCANPY-104 Update the package and script name to "pysonar"#174
Merged
guillaume-dequenne merged 3 commits intomasterfrom Mar 31, 2025
Merged
SCANPY-104 Update the package and script name to "pysonar"#174guillaume-dequenne merged 3 commits intomasterfrom
guillaume-dequenne merged 3 commits intomasterfrom
Conversation
guillaume-dequenne
force-pushed
the
SCANPY-104
branch
from
c7339de to
1f7a14a
Compare
Seppli11
approved these changes
Mar 31, 2025
Contributor
Seppli11
left a comment
Seppli11
left a comment
There was a problem hiding this comment.
LGTM! Thanks for doing the renaming.
I've left a few very minor nitpicks
|
|
||
| ``` | ||
| pysonar-scanner -Dtoml.path="path/to/pyproject.toml" | ||
| pysonar -Dtoml.path="path/to/pyproject.toml" |
Contributor
There was a problem hiding this comment.
nitpick: wouldn't make sense to use the pythonic param names here?
Suggested change
| pysonar -Dtoml.path="path/to/pyproject.toml" | |
| pysonar --toml-path "path/to/pyproject.toml" |
Contributor
Author
There was a problem hiding this comment.
I made the change. Note that the README still mentions the following:
Analysis properties can be provided as CLI arguments to the `pysonar` command.
They follow the same convention as when running the SonarScanner CLI directly
(see [documentation](https://docs.sonarsource.com/sonarqube/9.9/analyzing-source-code/scanners/sonarscanner/#running-from-zip-file)).
This means that analysis properties provided that way should be prepended with `-D`, for instance:
Which should probably be tackled in the SONARPY-156 about updating documentation.
|
|
||
| ``` | ||
| pysonar-scanner -Dsonar.projectHome="path/to/projectHome" | ||
| pysonar -Dsonar.projectHome="path/to/projectHome" |
Contributor
There was a problem hiding this comment.
same thing here:
Suggested change
| pysonar -Dsonar.projectHome="path/to/projectHome" | |
| pysonar --sonar-project-home "path/to/projectHome" |
Contributor
There was a problem hiding this comment.
nitpick: This file should probably be pysonar-debug now.
guillaume-dequenne
force-pushed
the
SCANPY-104
branch
from
5461788 to
b741619
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCANPY-104