Improve monorepo scan diagnostics and guidance - #325
Merged
Conversation
lelia
added
publish-preview
|
🚀 CLI preview published: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.7.0.dev3321567765801TestPyPI's package index can take several minutes to expose a newly uploaded version. |
lelia
added
publish-preview
|
🐳 Docker preview published: This mutable tag is only created when a Docker preview is explicitly requested. |
Contributor
Author
|
bugbot run |
lelia
added
publish-preview
lelia
removed
publish-preview
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3d8cdb3. Configure here.
lelia
added
publish-docker-preview
The mechanics of --sub-path and --workspace-name were documented, but not the choice they force. One combined scan gives a single dashboard entry and no per-component attribution; one scan per component gives attribution, baselines and per-component policy, but adds a repository entry per component, which grows the dashboard's repository list. There is no layout that provides both today. Customers hit this at a dozen-plus components and reasonably assume they have configured something wrong. Naming the trade-off, and adding rules of thumb for picking a side, is cheaper than each of them discovering it. Cross-referenced from the CI/CD guide's independent-workspace pattern, which is the layout that grows the list. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Phil Gran (philgran)
approved these changes
Sep 9, 2026
lelia
added a commit
that referenced
this pull request
Sep 11, 2026
main shipped 2.8.0 (#325 monorepo scan diagnostics and API exit codes, #331 Slack severity normalization and the socketdev 3.6.0 bump) while this branch was open, so the 2.7.3 it targeted is now behind the published release. Conflict resolution, in every case keeping main's shipped behaviour and this branch's formatting and fixes: - slack.py: kept the "middle" -> "medium" normalization from #331, restyled to double quotes. Losing it would have silently reintroduced the wrong Slack severity counts. - socketcli.py: kept #325's _log_scan_mode_fallback diagnostics and the force_api_mode branch; this branch's side was the older logic reformatted. - core/__init__.py: kept #325's _log_scan_configuration helper and its call sites, and the switch from sys.exit to raise so API failures reach the configured infrastructure exit code. Kept this branch's contextlib.suppress cleanup and modern annotations, and modernized the helper's own signature since this branch drops the typing.List/Optional imports. - version-check.yml: already assembled from main plus the enforcement gating and this branch's both-quote version strip. - CHANGELOG: this branch's section is now 2.8.1, above the shipped 2.8.0. uv.lock regenerated from the merged pyproject with the pinned uv 0.12.8. ruff check and ruff format are both clean; 584 passed, 2 skipped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
uv run pytest -q tests/unit tests/core— 532 passed, 2 skippedactionlinton the documented workflowgit diff --checkPublic Changelog
Improved monorepo scan diagnostics and guidance, with consistent API-error exit-code handling.
Refs: CE-436