You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A problem could be, anyway, that display-name may be fired after all peers display, so there is no (really) simple way then to remove a peer already displayed.
Activity
mwy001 commentedon Nov 3, 2022
I also see this. Does it happen when you toggle the device's network connection? (Turn off the wifi connection, when turn it on again)
brunetton commentedon Nov 3, 2022
No I didn't toggled the network connection at all
Bellisario commentedon Nov 4, 2022
An easy way to list device twice is to open Snapdrop in two different tabs (load the first, then the second).
I think this behavior can be easily modified here:
https://github.com/RobinLinus/snapdrop/blob/cc9c2bf088d5b2bb1316b35f8a420fa1e305fc2b/client/scripts/network.js#L30
https://github.com/RobinLinus/snapdrop/blob/cc9c2bf088d5b2bb1316b35f8a420fa1e305fc2b/client/scripts/network.js#L45
A problem could be, anyway, that display-name may be fired after all peers display, so there is no (really) simple way then to remove a peer already displayed.
mwy001 commentedon Nov 4, 2022
The "peers" message (notify peer about the other peers) returned from the WS server may include the calling/current peer. It should be excluded.
I have a possible fix for this:
RobinLinus/snapdrop@f1a5b0d
Bellisario commentedon Nov 4, 2022
@mwy001 I think that's a very good fix!
Is there any pull request for this? I don't see it on Snapdrop pulls.
mwy001 commentedon Nov 4, 2022
@Bellisario Thanks for the comments. Pull request created:
https://github.com/RobinLinus/snapdrop/pull/528