fix(JSONMissingBlock): allow app block references#1230
Open
chippleh1392 wants to merge 1 commit into
Open
Conversation
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Fixes a false positive where
JSONMissingBlockreports app block references as missing local block files when the containing schema allows@app.App block references use
shopify://apps/...types and do not map to localblocks/*.liquidfiles. This change skips local file validation for those references while still requiring the containing section or block schema to include@app.Regression coverage includes schemas allowing
@appwith@theme, schemas allowing only@app, and schemas that do not allow app blocks.Fixes #1144
What's next? Any followup issues?
None planned.
Tophatting
Run Theme Check against a JSON template containing a
shopify://apps/...block reference:@appin the containing schema,JSONMissingBlockdoes not report an offense.@app,JSONMissingBlockreports that the block type is not allowed.Validation completed:
pnpm buildCI=true pnpm exec vitest runpnpm type-checkpnpm format:checkBefore you deploy
changeset