Skip to content

fix(JSONMissingBlock): allow app block references#1230

Open
chippleh1392 wants to merge 1 commit into
Shopify:mainfrom
chippleh1392:repro/issue-1144-json-missing-block
Open

fix(JSONMissingBlock): allow app block references#1230
chippleh1392 wants to merge 1 commit into
Shopify:mainfrom
chippleh1392:repro/issue-1144-json-missing-block

Conversation

@chippleh1392

Copy link
Copy Markdown

What are you adding in this PR?

Fixes a false positive where JSONMissingBlock reports app block references as missing local block files when the containing schema allows @app.

App block references use shopify://apps/... types and do not map to local blocks/*.liquid files. This change skips local file validation for those references while still requiring the containing section or block schema to include @app.

Regression coverage includes schemas allowing @app with @theme, schemas allowing only @app, and schemas that do not allow app blocks.

Fixes #1144

What's next? Any followup issues?

None planned.

Tophatting

Run Theme Check against a JSON template containing a shopify://apps/... block reference:

  • With @app in the containing schema, JSONMissingBlock does not report an offense.
  • Without @app, JSONMissingBlock reports that the block type is not allowed.
  • Local block validation continues to report missing or disallowed local blocks.

Validation completed:

  • pnpm build
  • CI=true pnpm exec vitest run
  • pnpm type-check
  • pnpm format:check

Before you deploy

  • I included a patch bump changeset

@chippleh1392 chippleh1392 requested a review from a team as a code owner June 9, 2026 03:10
@chippleh1392

Copy link
Copy Markdown
Author

I have signed the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSONMissingBlock false positive for app block when section supports both @app and @theme

1 participant