Repository navigation
[SCF-2416] [Part 7] Keep Bootstrap 3 and subclassing, drop their deprecations - #22
Open
Gaurav0 wants to merge 1 commit into
Conversation
This fork will not remove Bootstrap 3 support or subclassing of the component classes, so neither should warn that it is going away. Subclassing (port of upstream ember-bootstrap#2049, "Drop component subclassing deprecation", released in upstream 6.2.0): - addon/utils/deprecate-subclassing.js and every @deprecateSubclassing are removed, along with the '__ember-bootstrap_subclass' escape-hatch fields on the four internal subclasses that used it. - Unlike ember-bootstrap#2049, BsProgress and NavbarContent stay empty classes instead of becoming templateOnly(), which can't be subclassed. - The API docs no longer say subclassing "is generally not supported, and may break at any time"; they say it is supported. - The subclassing test now checks that a subclass of each of the 15 public components renders with no deprecations, replacing the two tests per component that asserted and silenced the deprecation. Bootstrap 3: index.js no longer warns at build time that Bootstrap 3 support "will be removed in ember-bootstrap v5". The Glyphicon warning for Bootstrap 4/5 stays; it is a configuration hint. README: the intro says Bootstrap 3, 4 or 5, and a new "About this fork" section explains git-tag installs, the independent version numbers, and that Bootstrap 3 and subclassing stay supported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
[SCF-2416] [Part 2] Upgrade test and lint tooling (ESLint 8, Prettier 3, ember-try 3, stylelint)
#17
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fork will keep Bootstrap 3 support and subclassing of the component classes, so neither should warn that it's going away.
addon/utils/deprecate-subclassing.js, every@deprecateSubclassingand the__ember-bootstrap_subclassescape-hatch fields are removed.templateOnly(), so they can still be subclassed.index.jsno longer warns at build time that support "will be removed in ember-bootstrap v5". The Glyphicon hint for Bootstrap 4/5 stays.45 files, +39/−151 lines. No dependency or
yarn.lockchanges.Stack
Part of the SCF-2416 work (ember-bootstrap 5.0.0), split from
scf-2416-reworkfor easier review. This is part 7 of 9. Stacked on Part 6: its base isgaurav/chore/SCF-2416-part-6-upgrade-addon-deps, so the diff only shows this part. Merge in order.Review notes
Most of the 45 files only drop the import and decorator. Look at
tests/integration/components/subclassing-test.js,index.jsand the README section.Testing
Run on this branch with Node 20.19.6:
yarn install --frozen-lockfilepasses,yarn lintreports 0 errors (the same 150 warnings asscf_master), andember test(Ember 4.8, the default) has 535 passed, 9 skipped and 0 failed. −15: the subclassing test now has one test per public component instead of two (assert the deprecation, then silence it). CI covers the ember-try matrix.🤖 Generated with Claude Code