Repository navigation
chore(deps): update dependency react-router to v8.5.0 - #4368
Conversation
|
9f75574 to
7891e01
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Pushed f8db82e after examining both full test artifacts from native job 119088433625: 167/169 targets passed; seven MCP tests and two daemon unit tests timed out waiting for index readiness.
Their last snapshots had sealed source generations but stopped before text-builder initialization. The branch still had the independently confirmed synthetic-margin accounting defect, so this commit reuses #4393's canonical atomic sizing/charging correction and #4379's cgroup-headroom regression. No memory ceiling, timeout, or retry policy is increased.
It also fixes a concrete progress-reporting defect: pre-build ResidentMemoryRefused from either worker admission or artifact admission now publishes the existing ResidentMemory blocked reason through the generation/owner-epoch guarded progress slot. Added a native regression that holds a real ledger reservation, checks repeated refusal with no leaked charge, releases it, observes the canonical headroom notification, and requires the same retained owner to reach Ready with its block cleared. The unit fixture's timeout now includes its existing phase label, distinguishing initial readiness from a later save handoff.
Independent source review, pinned rustfmt, diff checks, and commitlint pass. Native execution remains with fresh CI. The old snapshots and later memory_headroom wakes are consistent with this admission path, but the log contains no contemporaneous memory sample proving these defects caused all nine timeouts.
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Pushed 32fef3e with the same reviewed source/test fix as #4393 for delayed memory refusals overwriting newer text progress.
Artifact refusals publish before their existing projection claim is released; worker-entry refusals are conditional on the unchanged observed progress epoch. The old outer reclassification is removed. Ready rejects stale blocks and clears earlier refusal state after verified query owners are installed. The regression coverage includes newer pending/Ready progress, owner replacement, retained admission recovery, and direct finalized-artifact publication to Ready.
Both changed blobs are identical to #4393's reviewed fix; all other branch content is preserved. Pinned rustfmt, diff checks and commitlint pass. Native tests await fresh Bazel CI; the earlier readiness timeouts are not claimed to be fully explained by the old logs.
Bring the merged settings editor and transcript fixture changes into the React Router update so CI validates their combined behavior.
This PR contains the following updates:
8.4.0→8.5.0Release Notes
remix-run/react-router (react-router)
v8.5.0Compare Source
Minor Changes
<ViewTransition>component, available in React 19.3 and later (#15493)viewTransitionprops/options,useViewTransitionState, andNavLink'sisTransitioningrender prop andtransitioningclassPatch Changes
<Await>failing to server render promises decoded from an RSC payload, which caused the Suspense boundary to switch to client rendering (#15597)@types/reactand@types/react-domas optional peer dependencies so the shipped type definitions resolve React types under strict (non-hoisted) node_modules layouts (#15528)unstable_useRouterStatedocumentation example to call the imported alias (#15535)HydrateFallbackof a route discovered throughpatchRoutesOnNavigationduring initial hydration (#15537)state.matcheswhile their loaders run, so<RouterProvider>renders down to the discovered route'sHydrateFallbackinstead of rendering nothingRouterProvidersubscribes, including when other subscribers are already attached, and report current client errors once without replaying server errors during hydration (#15637)matchPathnot treating a static segment as optional when it contains characters outside[\w-](#15425)fetcher.reset(), so its cleared data no longer comes back on the next revalidation (#15633)Unstable Changes
unstable_fetchprop to<HydratedRouter>to customize JavaScript-issued manifest and server data requests in conventional Framework Mode (#15586)navigationType("PUSH","REPLACE", or"POP"for navigation-initiated requests, including reloaded fetchers;nullotherwise)unstable_initiatorandunstable_navigationTypetypeto"navigation"guarantees a non-nullnavigationType, while other data requests have anullnavigationType"initialization"type and include their fetcher key<Link prefetch>use native<link rel="prefetch">elements and do not call the custom implementationunstable_useRouteDiscoveryfor application-controlled route discovery in conventional Framework Mode (#15602)loadAllRoutes()future.unstable_customRouteDiscoveryto opt inevent.defaultBehavior()from a custom mismatch handler to explicitly run built-in recoverynext()Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Integration fixes and validation
The branch also carries the shared text-artifact memory-admission and blocked-progress repairs. The latest CI failures in both Linux fleet prebuild and Clippy were the same test compilation error: the native headroom receiver's
has_changed()returnsbool, so the assertion must use it directly instead of calling.expect(). The correction preserves the notification and recovery assertions.pnpm installfor the changed lockfile; supply-chain validation passed.-D warnings; formatting, diff checks, and commit-message validation passed.