Repository navigation
Run project-server lifecycle on Asupersync - #4361
ScriptedAlchemy with Copilot wants to merge 14 commits into
Conversation
|
Co-authored-by: ScriptedAlchemy <25274700+ScriptedAlchemy@users.noreply.github.com>
dbde759 to
f2db3d7
Compare
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Re-reviewed d14005c and cross-referenced #3736, including its recent progress updates. The new delta only reorders an import; no new concrete source defect found in the lifecycle/retirement slice.
I changed the PR body's Fixes #3736 to Refs #3736. This patch completes focused project-server timer/retirement ownership work, but the broad issue still has runtime seams and execution acceptance to track: native_runtime::handle() retains a production process_runtime() fallback in crates/tracedecay-rusqlite-runtime/src/native_runtime.rs:42–43, and this PR does not supply the owning-suite/platform, storage-wait, or paired performance/thread-use evidence required by the updated issue. Historical entry-point/framing/git/headroom migrations already recorded as landed are not being reopened.
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Pushed f07293a. Removed the three forwarding lifecycle hop wrappers and their module, imported the canonical lifecycle functions directly, and removed the obsolete Tokio-context comment. This completes the caller cutover without adding a compatibility facade.
Pinned rustfmt, commitlint, git diff --check, and the ambient-Tokio repository gate pass (2,509 production source files checked). Native lifecycle execution remains pending CI.
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Fixed the current Clippy E0308 failures in ee130e4. The production harness shutdown and the two affected lifecycle tests now create std::time::Instant deadlines, matching the canonical native shutdown helpers. Audited all remaining calls to both helpers; no wrappers or timeout changes were added.
Pinned rustfmt, diff checks, and commitlint passed. The three compiler errors came from the current CI job; the new head is pushed for CI compilation and existing shutdown tests. Native builds were not rerun in the constrained local environment.
Use the canonical asynchronous SQL reader for persisted scope lookup and CAS admission while preserving the foreground priority and read budget. Exercise real native-task CAS, readback, and stale-revision conflict requests and assert that scope-set reads do not park native workers.
Summary
Motivation
Project-server lifecycle paths still depended on Tokio timers and task spawning, requiring native callers to hop into Tokio.
Changes
std::time::Instantandnative_runtime::timeoutfor lifecycle waits; pass deadlines directly from shutdown callers.NativeTask. Cancellation reports failure rather than clean completion; detached cleanup remains owned after the caller drops its wait.Test plan
bazel build //...passes when the change crosses package boundariesBazel tests could not start because the launcher could not resolve the host to download Bazel 9.3.0.
Checklist
CHANGELOG.mdupdated (under[Unreleased]if no version bump).envfiles includedReview and CI follow-up
Pinned formatting, whitespace checks, commitlint, and independent source/API/lifetime review passed. Native compilation and regression execution remain pending in Bazel CI.