Verifier: catch classes silently dropped across declarations#4
Merged
Conversation
check_self_conflicts only inspects one declaration at a time, so a class dropped when a base and an axis rule merge together (e.g. leading-snug overridden by a size axis's text-sm) slips through unreported. Added: Verifier cross_declaration_conflicts check warning on classes silently dropped when separate DSL declarations merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_self_conflictsonly looks at one declaration at a time, so a class that gets silently dropped when a base and a variant are merged together slips through. The common shape:Tailwind font-size utilities carry a default
line-height, sotailwind_mergedropsleading-snug— no error, no warning, it just never reaches the DOM.Adds a
cross_declaration_conflictscheck that simulates the base + axis merge for every axis combination and reports declared classes the merge silently removes. It's a warning, not an error: cross-declaration drops are often deliberate variant overrides. To keep signal high it suppresses same-family overrides (p-2→p-8) and surfaces only drops where the winner is a different utility family (leading-snugdropped bytext-sm) — the surprising ones.