New test and fixes for AlwaysBuild when using ninja execution engine.#4871
Open
pmova7173630 wants to merge 1 commit into
Open
New test and fixes for AlwaysBuild when using ninja execution engine.#4871pmova7173630 wants to merge 1 commit into
pmova7173630 wants to merge 1 commit into
Conversation
mwichmann
reviewed
Jul 1, 2026
| node_callback(env, node, build) | ||
|
|
||
| if node.always_build: | ||
| build["inputs"] = build.get("inputs", []) + ["SconsAlwaysBuildPhony"] |
Collaborator
There was a problem hiding this comment.
Would 'implicit' be better than 'inputs' here? (it's a question - I don't actually know)
bdbaddog
reviewed
Jul 1, 2026
| From John Doe: | ||
| - Whatever John Doe did. | ||
|
|
||
| From Paul Movall: |
Contributor
There was a problem hiding this comment.
Please add your blurb order by last name among contributors to this release.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a new end-to-end test to verify that AlwaysBuild works correctly with the ninja execution engine. Provide fixes for that support. Updates to the required text files to document the fixes.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).