SapMachine (21) #2250: Add adjustments to heap dumps for the buildpack#2281
Open
schmelter-sap wants to merge 2 commits into
Open
SapMachine (21) #2250: Add adjustments to heap dumps for the buildpack#2281schmelter-sap wants to merge 2 commits into
schmelter-sap wants to merge 2 commits into
Conversation
Member
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
Member
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
RealCLanger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the same features for the heap dump changes in the buildpack done in 25+ to 21.
Since 21 doesn't have the problematic segemented heap dump, the fixes for that are omitted. The -XX:HeapDumpParallelism is kept for compatibility from 25+, but has no effect here (you cannot set the number of threads used for the heap dump in this implementation).
Additionally the checks for not triggering a "normal" segmented heap dump in the test was removed.
fixes #2250