fix(webaudio): resolve issues with atomics support#1225
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses WebAudio behavior in wasm builds by making availability detection more accurate and avoiding unsound Send + Sync assertions when wasm atomics are enabled.
Changes:
- Splits WebAudio
Streamstorage/control paths between non-atomics and atomics builds. - Routes atomics
play/pausethrough a main-threadspawn_localtask. - Updates WebAudio availability checks and changelog entries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/host/webaudio/mod.rs |
Refactors WebAudio stream internals for atomics support and window-only availability. |
Cargo.toml |
Adds futures dependencies to the wasm-bindgen feature and reformats dependency lists. |
CHANGELOG.md |
Documents the WebAudio fixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
roderickvd
changed the title
roderickvd
force-pushed
the
fix/webaudio-atomics
branch
from
3ec31fa to
5e657b1
Compare
roderickvd
force-pushed
the
fix/webaudio-atomics
branch
from
5e657b1 to
bc55bac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Send + Syncassertion was unsound when compiled with+atomics.