setup release-plz 2#583
Draft
Firestar99 wants to merge 3 commits into
Draft
Conversation
Firestar99
force-pushed
the
setup-release2
branch
from
a4782bf to
2cede3c
Compare
Firestar99
force-pushed
the
setup-release2
branch
from
2cede3c to
2f1f6d6
Compare
The difftest workspace pulls `spirv-std` / `spirv-builder` via path deps, so its `Cargo.lock` references their versions. release-plz only bumps the root workspace, so add a follow-up step on the `release-pr` job that checks out the freshly-created release PR, runs a targeted `cargo update` against the difftest manifest for the five spirv-* packages, and pushes the resulting lockfile change back onto the PR before CI runs against it. Uses the documented "commit files to the release PR" pattern from release-plz so we don't need a config option upstream. `RUSTUP_TOOLCHAIN=stable` avoids rust-toolchain.toml auto-installing the pinned nightly just to refresh a lockfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
various bug fixes for release-plz after the first release
v{version}, eg.v0.10.0-alpha.1release-dry-runaction thatcargo publish --dry-runalpha.1release due to us adding a new feature to a crate and another crate depending on it, but as dry-run uses only crates releases, the latter crate would fail to build due to that feature not existing in the crates releaseCargo.lockon the release PR by checking it out after release-plz creates it and pushing a follow-upcargo updatecommit (per the release-plz docs), so CI on the release PR runs against a consistent lockfile (relates to Custom action afterrelease-prupdates versions release-plz/release-plz#2805)