Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
PYRIGHT_PYTHON_NODE_VERSIONis set, nodeenv currently installs with--forceeven when the requested Node version is already installed. Probe the installed Node executable before reinstalling, including when resolving npm, and reuse it only for a matching complete version. The probe has a five-second timeout; aliases, version changes, missing binaries, and failed or ambiguous probes retain installation.Fixes #319.
Validation:
The full-suite run before the timeout-test follow-up had 66 passing tests and one unchanged Node 13.1.0 test failing with
Bad CPU typeon macOS arm64. The same test fails against the original production source. The supported OS/Python runtime matrix has not been run locally.AI-assisted contribution.