fix: allow array-based identifiers in ignore file#587
Open
MatrixNeoKozak wants to merge 1 commit into
Open
Conversation
eoftedal
previously approved these changes
Jun 18, 2026
Author
|
Hi! Just checking in to see if there is anything else needed on this PR before it can be merged. Thanks! |
Member
|
The repository requires signed commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.retireignore.jsonschema innode/src/cli.tswas overly restrictive, only allowing single string values for identifiers in the ignore configuration. This prevented users from ignoring vulnerabilities that are identified by arrays (e.g., CVE lists) in the vulnerability repository. This change updates the Zod schema innode/src/cli.tsto support both string and array-of-strings values for identifiers, and updates thehasIdentifierfunction innode/src/scanner.tsto correctly handle array-based comparisons. This ensures that the ignore logic properly matches vulnerabilities even when multiple identifiers are provided or when the vulnerability repository uses array-based identifiers.