Skip to content

Reorganize code for CTMRG projector algorithms - #428

Merged
leburgel merged 3 commits into
QuantumKitHub:mainfrom
Yue-Zhengyuan:projectors-refactor
Sep 11, 2026
Merged

Reorganize code for CTMRG projector algorithms#428
leburgel merged 3 commits into
QuantumKitHub:mainfrom
Yue-Zhengyuan:projectors-refactor

Conversation

@Yue-Zhengyuan

Copy link
Copy Markdown
Member

This PR puts code for each projector algorithm into its own file, hopefully making the source tree cleaner and ready for addition of new projector algorithms (such as #263, #422).

@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.00000% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/algorithms/ctmrg/projectors/c4v_qr.jl 54.54% 5 Missing ⚠️
src/algorithms/ctmrg/projectors/c4v_eigh.jl 75.00% 4 Missing ⚠️
src/algorithms/ctmrg/projectors/fullinfinite.jl 75.00% 4 Missing ⚠️
src/algorithms/ctmrg/projectors/halfinfinite.jl 71.42% 4 Missing ⚠️
src/algorithms/ctmrg/projectors/projectors.jl 87.50% 4 Missing ⚠️
src/algorithms/ctmrg/c4v.jl 72.72% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/PEPSKit.jl 100.00% <ø> (ø)
src/algorithms/ctmrg/c4v.jl 73.75% <72.72%> (-10.04%) ⬇️
src/algorithms/ctmrg/projectors/c4v_eigh.jl 75.00% <75.00%> (ø)
src/algorithms/ctmrg/projectors/fullinfinite.jl 75.00% <75.00%> (ø)
src/algorithms/ctmrg/projectors/halfinfinite.jl 71.42% <71.42%> (ø)
src/algorithms/ctmrg/projectors/projectors.jl 87.50% <87.50%> (ø)
src/algorithms/ctmrg/projectors/c4v_qr.jl 54.54% <54.54%> (ø)

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leburgel leburgel self-assigned this Sep 8, 2026
@leburgel

leburgel commented Sep 8, 2026

Copy link
Copy Markdown
Member

Would it make sense to also split off the C4v projectors (C4vEighProjector and C4vQRProjector)?

Comment thread src/algorithms/ctmrg/projectors/projectors.jl
Comment thread src/algorithms/ctmrg/projectors/c4v_eigh.jl
Comment thread src/algorithms/ctmrg/projectors/c4v_qr.jl
Comment thread src/algorithms/ctmrg/projectors_c4v/qr.jl Outdated
@Yue-Zhengyuan

Yue-Zhengyuan commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

The test errors are due to upstream Julia 1.13 / VectorInterface compatibility issue: QuantumKitHub/VectorInterface.jl#54.

@leburgel
leburgel merged commit b00d08c into QuantumKitHub:main Sep 11, 2026
65 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants