perf: Use semi-join instead of unique for checking 1:N relationships#362
Open
Oliver Borchert (borchero) wants to merge 2 commits into
Open
perf: Use semi-join instead of unique for checking 1:N relationships#362Oliver Borchert (borchero) wants to merge 2 commits into
unique for checking 1:N relationships#362Oliver Borchert (borchero) wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 56 56
Lines 3475 3475
=========================================
Hits 3475 3475 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the require_relationship_one_to_at_least_one relationship helper by avoiding unnecessary unique() work on the RHS, using a semi-join to filter lhs rows based on key existence in rhs (improving runtime by reducing redundant hashing).
Changes:
- Replace
rhs.unique(on)+ inner join withhow="semi"joins to check key existence more efficiently. - Preserve the existing optional
lhs.unique(..., keep="none")behavior whendrop_duplicates=True.
Andreas Albert (AndreasAlbertQC)
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation builds two separate hash tables for no good reason. On some example data, this improves runtime of the filter itself by ~2.5x. End-to-end on the updated benchmark, it yields a ~5-10% runtime speedup.