Skip to content

feat: Add kwargs to Collection.collect_all()#361

Merged
Oliver Borchert (borchero) merged 3 commits into
mainfrom
collect-all-streaming
Jul 6, 2026
Merged

feat: Add kwargs to Collection.collect_all()#361
Oliver Borchert (borchero) merged 3 commits into
mainfrom
collect-all-streaming

Conversation

@ElisabethBrockhausQC

Copy link
Copy Markdown
Contributor

Motivation

It's currently not possible to specify the engine for .collect_all().

Changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the dy.Collection API to allow forwarding keyword arguments to polars.collect_all(), enabling callers to control Polars collection options (e.g., choosing an execution engine) when collecting all members of a collection.

Changes:

  • Add **kwargs to Collection.collect_all() and forward them to pl.collect_all(...).
  • Apply formatter-driven refactors that collapse several multi-line expressions into single-line equivalents.

Comment thread dataframely/collection/collection.py
Comment thread dataframely/collection/collection.py
@ElisabethBrockhausQC ElisabethBrockhausQC marked this pull request as ready for review July 6, 2026 16:37
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a523310) to head (4ae558d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #361   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3475      3475           
=========================================
  Hits          3475      3475           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@borchero Oliver Borchert (borchero) enabled auto-merge (squash) July 6, 2026 16:50
@borchero Oliver Borchert (borchero) merged commit 071d6b9 into main Jul 6, 2026
32 checks passed
@borchero Oliver Borchert (borchero) deleted the collect-all-streaming branch July 6, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants