Repository navigation
fix(selection): clear editor highlight when selection chip is deleted - #93
Merged
Merged
Conversation
Clicking the X on a captured selection chip removes the token from the composer input. The SelectionController noticed this and dropped the stored selection, but it forgot to clear the mock highlight shown in the editor (or preview CSS highlight). The highlight would linger because storedSelection was already null by the time any cleanup ran. Call clearHighlight() before nulling storedSelection so the CM6/CSS highlight is removed together with the chip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking the X on a captured selection chip removes the token from the composer input.
SelectionController.reconcileToken()noticed this and dropped the stored selection, but it did not clear the mock highlight shown in the editor (or the preview CSS highlight). The highlight would linger becausestoredSelectionwas alreadynullby the time any cleanup ran.Fix by calling
clearHighlight()before nullingstoredSelection.Test plan
npm test -- tests/unit/features/chat/controllers/selection-controller.test.tspasses (30 tests).hideSelectionHighlight) and preview-mode (CSS.highlights.delete) highlights are cleaned up when the chip token is removed.npm run typecheckpasses.