deprecate exception classes in Cursor attributes#782
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR deprecates accessing DB-API exception classes via Cursor attributes by replacing the existing cursor-level exception attributes with a BaseCursor.__getattr__ fallback that emits a DeprecationWarning and forwards lookups to the underlying exceptions module.
Changes:
- Remove cursor-level exception attributes previously defined on
BaseCursor. - Add
BaseCursor.__getattr__to intercept exception attribute access and emit a deprecation warning. - Forward exception attribute lookups to
MySQLdb._exceptions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
==========================================
- Coverage 88.86% 88.75% -0.12%
==========================================
Files 7 7
Lines 548 560 +12
==========================================
+ Hits 487 497 +10
- Misses 61 63 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.