Bench: scale binary-trees/fannkuch for v2 wall budget (#36385) - #37720
Merged
Merged
Conversation
#36385) Depth 10 / n=8 timed out under the 25s VM cap and burned the full timeout with n/a columns. Scale to maxDepth=7 / n=6, honor @bench-skip-vm, and project wall from RESULTS in check-bench-readme-sync so the Done-when budget stays enforceable. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bench-gateextended to all of it (benchmarks/, script/bench-gate.php, docs/pages/bench.html) #36385 (lane B#36385 % 3 == 1; lane overflow: CI: php-llvm-structgep-assert.patch fails to apply — blocks north-star5-verify-fast and all bootstrap gates #36143–VM: 1M-iteration loops exit 255 silently — restore compute-suite headroom on bin/vm.php #36148 / RunForge north star (Sep 2026): trust, build speed, performance — automation tracker #36142 children closed; Distribution: platform matrix — linux/arm64 first (per-arch helper cache, CI on an arm64 runner or QEMU), then macOS arm64; a target-triple abstraction in Linker/TargetMachine instead of x86_64 assumptions (prelinked/helper-runtime/<arch>/, lib/AOT/Linker.php, lib/JIT/Context.php) #36391/Performance: v2.0 targets and the codegen roadmap to reach them — typed code ≥ 3x Zend, untyped ≤ 1.5x slower, web request ≥ php-fpm: inline caches for property/method access, escape analysis for arrays/strings, guarded speculation, per-function O1 by default (lib/JIT.php, lib/JIT/Builtin/Type/Object_.php, lib/JIT/Analyzer.php) #36386 claimed <48h by peers).binary-treesmaxDepth10→7 andfannkuch-reduxn 8→6 so VM/JIT finish under the 25s per-run cap (depth 10 / n=8 timed out and burned the full cap withn/acolumns).@bench-skip-vm: <reason>skips VM+JIT immediately;V2_WALL_BUDGET_SECnamed constant;check-bench-readme-sync.php --check-wall(also folded into default check) projects CLI wall from committedRESULTS.json(+120s overhead) and fails if >900s.BASELINE.json/RESULTS.jsonfor the scaled cases; README +docs/pages/bench.htmlregenerated.Test plan
./script/phpunit.sh --filter BenchGateTest→ 14/14php script/check-bench-readme-sync.php→ OK (projected CLI 345.8s + overhead 120s = 465.8s / budget 900s)php script/check-bench-readme-sync.php --check-wall→ OKphp script/check-size-budgets.php→ OKPHP_8_2=$(command -v php) php script/bench-gate.php --v2→ OK (ratio/geomean/IR vs baseline)./script/aot-smoke.sh→ 9/9 + size gate OKmake north-star5-verify-fast→ OKbench.php --v2end-to-end this run (projection gate + scaled remeasure of the two cases).Closes nothing — Part of #36385 (Done-when remaining: maintainer checkbox when all slices land).
Made with Cursor