fix: add kernel version#675
Conversation
gsprochette
left a comment
There was a problem hiding this comment.
Hello ! I just have some questions on the two changes. It looks super good but I need to understand what's going on before I can approve :)
| "piq", | ||
| "opencv-python", | ||
| "kernels", | ||
| "kernels<=0.14.1", |
There was a problem hiding this comment.
I'm not super sure why we need to pin a max version if the problem was that we need to specify a version as of 15.1 and this PR is doing that. Is there still a bug even after specifying a version?
Also, why 14.1?
There was a problem hiding this comment.
Ah ok I only now understood that transformers itself doesn't yet specify versions yet so we do this until they specify versions in a new release, perfect 👍
There was a problem hiding this comment.
Let's just leave a comment explaining the reason of the pin I would say
gsprochette
left a comment
There was a problem hiding this comment.
I understood the answer to my question only after my first review. I left two comments:
- first is just double check on the FA3 kernel version and tests
- second is me getting confused and finally just asking for a comment :)
Is there a plan to make transformers compatible with kernels>=15.1 on the HF side? Like is there an open PR or an issue we can reference and check in the future if it's time to remove the kernels pin?
Thanks a lot for finding this bug and fixing it :)
| "piq", | ||
| "opencv-python", | ||
| "kernels", | ||
| "kernels<=0.14.1", |
There was a problem hiding this comment.
Let's just leave a comment explaining the reason of the pin I would say
Description
Transformers (even dev or >=5.0) is not compatible with kernels>=0.15.
It raises the following error in tests:
This us due to the kernel version requirement: https://github.com/huggingface/kernels/releases/tag/v0.15.1
To fix it:
Related in prunatree: https://github.com/PrunaAI/prunatree/pull/470
No fixes btm on HF: huggingface/transformers#46291
Fixes #(issue number)
Type of Change
Testing
uv run pytest -m "cpu and not slow")For full setup and testing instructions, see the Contributing Guide.
Checklist
Thanks for contributing to Pruna! We're excited to review your work.
New to contributing? Check out our Contributing Guide for everything you need to get started.