Skip to content

ci: observe Python 3.12 full-dependency resolution - #9140

Open
agourakis82 wants to merge 2 commits into
Project-MONAI:devfrom
agourakis82:9069-py312-full-dep-observability
Open

agourakis82 wants to merge 2 commits into
Project-MONAI:devfrom
agourakis82:9069-py312-full-dep-observability

Conversation

@agourakis82

Copy link
Copy Markdown

Related to #9069. This is a first CI observability step, not a compatibility fix.

Description

Add an informational Ubuntu/Python 3.12 job that installs .[all,testing], runs pip check, and uploads pip freeze as an artifact. The existing Python 3.10 full-dependency test matrix and package bounds are unchanged. The new job does not run the unit suite or establish Python 3.12 compatibility.

Validation

  • Parsed the updated workflow with yq.
  • git diff --check passed.
  • Did not run MONAI unit tests locally; this change is limited to CI configuration.

Types of changes

  • Non-breaking CI change.
  • New tests added.
  • Integration tests passed locally.
  • Quick tests passed locally.

Assisted by Codex.

Add an informational Ubuntu job that installs all optional and test dependencies on Python 3.12, checks the resolved environment, and uploads a version snapshot. Keep the existing Python 3.10 full-dependency matrix unchanged.

Assisted-by: OpenAI Codex
Signed-off-by: Demetrios Agourakis <demetrios@agourakis.med.br>
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Project-MONAI/MONAI/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b47bc604-4dba-49c3-8f1f-2a00c5fe6d7d

📥 Commits

Reviewing files that changed from the base of the PR and between cf3e11b and daab1c7.

📒 Files selected for processing (1)
  • .github/workflows/cicd_tests.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Adds an Ubuntu job that runs with Python 3.12 when test_skip indicates tests are required. The job installs the full dependency set, runs pip check, and uploads a frozen package list regardless of earlier step outcomes. It has a 90-minute timeout and can fail without failing the workflow.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to daab1

The informational Python 3.12 dependency check does not establish a merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: observing Python 3.12 full-dependency resolution in CI.
Description check ✅ Passed The description explains the change, scope, validation, limitations, and change type. It is mostly complete despite not using the exact issue-heading format and omitting some unused template options.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@agourakis82

Copy link
Copy Markdown
Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@agourakis82
agourakis82 marked this pull request as ready for review September 29, 2026 18:16
Copilot AI balanced review requested due to automatic review settings September 29, 2026 18:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The isolated, non-blocking workflow job matches the stated observability scope and preserves existing CI behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Adds a non-blocking Python 3.12 CI job to observe full dependency resolution without changing compatibility guarantees or existing matrices.

Changes:

  • Installs all testing dependencies and runs pip check.
  • Uploads the resolved environment from pip freeze.
File Description
.github/​workflows/​cicd_tests.yml Adds the informational Python 3.12 dependency-resolution job.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants