Fix allowing empty string to be passed to resources#1544
Open
SteveL-MSFT wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DSC expression parser to allow empty-string property values to flow through expression evaluation without failing parsing, addressing #1542.
Changes:
- Treat a tree-sitter root parse error as a literal string value instead of a parser error.
- Add a Pester test validating that an empty string property value is preserved through
dsc config get.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/dsc-lib/src/parser/mod.rs | Adjusts root-node parse error handling so empty strings can be passed as literal values. |
| dsc/tests/dsc_expressions.tests.ps1 | Adds coverage for empty-string property values during expression evaluation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The existing code always tries to parse a string as an expression and handles specific cases where it fails to have it as a literal. In the case like an empty string, the parser fails immediately so there's no chance to pass an empty string.
The fix checks if the trimmed statement is empty and if so, passes it back as a string literal instead of trying to parse.
PR Context
Fix #1542