fix(inbox): fix some inbox papercuts#2151
Open
joshsny wants to merge 8 commits into
Open
Conversation
- Drop yellowish row background for suggested-reviewer cards; the eye badge alone is enough to indicate suggestion and the amber tint read as "highlighted" - Normalize the suggested-reviewer badge height to match P2/Actionable by removing its leading-none override - Increase the gap between title and badges (and badges and summary) in compact list rows - Clamp the list-row summary to 3 lines (was 4) - Round the sidebar Inbox "Alpha" badge to match the rest of the sidebar's rounded pills Generated-By: PostHog Code Task-Id: 9fcb5fbc-ec76-4b37-a0bc-dc4556c0d8a6
Revert the eye-badge leading override, the compact column gap bump, and the sidebar Alpha badge radius — those were already in place; the earlier commit was made against a stale local copy. Keeps only the two genuinely new fixes: removing the suggested-reviewer row tint and clamping the list summary to 3 lines. Generated-By: PostHog Code Task-Id: 9fcb5fbc-ec76-4b37-a0bc-dc4556c0d8a6
Drop the trailing "task" in the relationship labels shown on the report detail task bars and in the matching pending-state tooltips. The "task" suffix was redundant context — the bar itself already denotes a task. Generated-By: PostHog Code Task-Id: 9fcb5fbc-ec76-4b37-a0bc-dc4556c0d8a6
Plain-clicking the already-selected report was calling clearSelection, which dropped the user back to the "Select a report" empty state — not expected. Dropping the toggle-off branch so the second click is a no-op (the row stays selected); cmd-click still toggles selection as before. Generated-By: PostHog Code Task-Id: 9fcb5fbc-ec76-4b37-a0bc-dc4556c0d8a6
The button was switching to "Implement as new task" whenever the report was awaiting human input, even though clicking it does the same thing either way — kick off onCreateImplementationTask. Always show the user-meaningful "Create PR" label. Generated-By: PostHog Code Task-Id: 9fcb5fbc-ec76-4b37-a0bc-dc4556c0d8a6
- Remove the "Weight: x.x" badge from signal card headers. It was noisy internal detail with no actionable meaning for the reviewer. - For error_tracking signals, render a "View issue" link in the card using signal.source_id (the issue UUID). Mirrors the existing "View on GitHub" / Zendesk "Open" links on other source-specific cards. Adds errorTrackingIssueUrl() to the shared posthogLinks helpers so it picks up the user's cloud region and project id. Generated-By: PostHog Code Task-Id: 9fcb5fbc-ec76-4b37-a0bc-dc4556c0d8a6
Drop the "Unverified" rendering of VerificationBadge — showing a gray "Unverified" chip on every unverified signal added noise without adding signal. The badge now only renders when finding.verified is true. Generated-By: PostHog Code Task-Id: 9fcb5fbc-ec76-4b37-a0bc-dc4556c0d8a6
The Create PR button sat on the bottom implementation task bar, which felt like an out-of-the-way place for the primary action on a report. Move it to the header next to Dismiss so all top-level controls live in one corner. Header right-side order is now: copy-link, Dismiss, (Create PR | View PR pill), close. The Create PR button and View PR pill are mutually exclusive — same slot, same role. Drops the now-unused onCreateImplementationTask / isAwaitingInput plumbing from ReportTaskLogs along with the run-action button JSX and the role="button" workaround that only existed so the nested run button could coexist with the expand toggle. Generated-By: PostHog Code Task-Id: 9fcb5fbc-ec76-4b37-a0bc-dc4556c0d8a6
joshsny
changed the title
Contributor
|
Reviews (1): Last reviewed commit: "fix(inbox): move Create/View PR action i..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A bunch of small things were annoying me in the inbox UI, here are fixes for them, don't think anything here is 🌶️
Signals inbox list
Signal cards (report detail)
signal.source_idvia a newerrorTrackingIssueUrl()helper that picks up the user's cloud region and project id), mirroring the existing "View on GitHub" / Zendesk "Open" links.Report detail header & task bars
onCreateImplementationTask/isAwaitingInputplumbing fromReportTaskLogsand therole="button"workaround that only existed so the nested run button could coexist with the expand toggle.Interaction
clearSelection()(and no longer drops the user back to the "Select a report" empty state). Cmd-click still toggles; shift-click still range-selects.