fix(code): make toast close button clickable#2145
Merged
Merged
Conversation
The X button on toasts swallowed clicks because sonner's pointerdown handler only short-circuits when event.target is a BUTTON; clicking the SVG icon made it the target, sonner engaged swipe handling, and the button's onClick never fired. Disable pointer events on the icon so the button itself is always the target. Generated-By: PostHog Code Task-Id: 50570d7f-97f6-4f2a-b88e-45fb836a1061
Contributor
|
Reviews (1): Last reviewed commit: "fix(code): make toast close button click..." | Re-trigger Greptile |
adboio
approved these changes
May 14, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<li>only short-circuits whenevent.target.tagName === 'BUTTON'. Clicking the X made the SVG icon the event target, so sonner calledsetPointerCaptureon the SVG and engaged its swipe logic, swallowing the click before the IconButton'sonClickcould firesonnerToast.dismiss(id).pointer-events-noneto the<XIcon>so the click target is always the button itself, which hits sonner's BUTTON early-return.Test plan