feat: add pokemon_form_flavor_text (per-form flavor text) - #1629
Open
MiquelRForgeFlow wants to merge 1 commit into
Open
feat: add pokemon_form_flavor_text (per-form flavor text)#1629MiquelRForgeFlow wants to merge 1 commit into
MiquelRForgeFlow wants to merge 1 commit into
Conversation
MiquelRForgeFlow
force-pushed
the
master-add-form-flavor_text
branch
2 times, most recently
from
August 20, 2026 13:43
48d4ab6 to
13c2a7d
Compare
New PokemonFormFlavorText model/table exposing flavor_text_entries on /pokemon-form, mirroring the species-level table. Populated for Generation III, where Deoxys is the only Pokémon with form-specific Pokédex entries Its form was fixed per game version (Ruby/Sapphire → Normal, FireRed → Attack, LeafGreen → Defense, Emerald → Speed). Gens I–II have no form-specific entries; later generations are left for follow-up PRs.
MiquelRForgeFlow
force-pushed
the
master-add-form-flavor_text
branch
from
August 20, 2026 14:25
13c2a7d to
43baa06
Compare
MiquelRForgeFlow
marked this pull request as ready for review
August 20, 2026 14:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
PokemonFormFlavorTextmodel/table, exposingflavor_text_entrieson/pokemon-form/{id}. It mirrors the existing species-levelpokemon_species_flavor_text, so forms that had their own Pokédex entries can carry them explicitly.Scope
Populated for Generation III only, the earliest generation with form-specific Pokédex entries:
Later generations have more form-specific entries and are intentionally left for follow-up PRs, which keeps this one small and easy to review.
Text is copied verbatim (including line breaks and page-break characters) from the matching
pokemon_species_flavor_textrows, re-keyed to the correctpokemon_form_id. English is the only language present for these entries.Changes
PokemonFormFlavorTextmodel + migration.flavor_text_entrieson the pokemon-form detail endpoint.build.pyloader +pokemon_form_flavor_text.csv(5 rows).Open question for reviewers
These 5 Gen III Deoxys entries currently also live in
pokemon_species_flavor_text(versions 7–11), where they read as generic species entries even though they're really forme-specific.I've kept them in place, because:
/pokemon-species/deoxysis the common path consumers read; removing them would leave the species with no Gen III flavor text, which is a backwards-incompatible change.That said, one could argue they're now redundant and better represented here, so they could be dropped from the species table. I'm happy to do that (here or in a follow-up) if maintainers prefer. I'm flagging it so you can decide.
AI coding assistance disclosure
Checking everything I did is fine.
Contributor check list