Skip to content

fix: remove 'keep-project' as its not provided on all levels of process-compose - #113

Merged
srid merged 4 commits into
Platonic-Systems:mainfrom
gabyx:fix/keep-project-flag
Oct 14, 2026
Merged

srid merged 4 commits into
Platonic-Systems:mainfrom
gabyx:fix/keep-project-flag

Conversation

@gabyx

@gabyx gabyx commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Make the top-level flag keep-project deprecated as it should not be set due to: F1bonacc1/process-compose#525 (comment)
Its only allowed on up etc and does not work with most commands. and therefore its better to not having it set into the wrapper.

Assited-by: no agent.

@gabyx

gabyx commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@srid: Is there a better way to have deprecation?

@srid

srid commented Oct 6, 2026

Copy link
Copy Markdown
Member

@gabyx I'd prefer that we just remove it entirely.

@gabyx
gabyx force-pushed the fix/keep-project-flag branch 2 times, most recently from 6a30373 to 323b2c7 Compare October 7, 2026 08:12
@gabyx
gabyx force-pushed the fix/keep-project-flag branch from 323b2c7 to 959f58f Compare October 7, 2026 08:13
@gabyx

gabyx commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@srid: I removed the flag.

@gabyx gabyx changed the title fix: add deprecation to 'keep-project' fix: remove 'keep-project' as its not provided on all levels of process-compose Oct 13, 2026

@srid srid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Blocking: option removed, but its consumer is still there — branch doesn't evaluate

nix/process-compose/cli.nix:157 still reads the deleted option:

++ (lib.optionals o.keep-project [ "--keep-project" ])

Reproduced with example/ overriding process-compose-flake to this branch:

error: attribute 'keep-project' missing
at .../nix/process-compose/cli.nix:157:31

Every makeProcessCompose / process-compose.<name> consumer fails; CI build jobs will fail the same way once approved. Deleting that line is the missing part of the diff.

🟢 Scope is right

Ran process-compose v1.122.0 with each flag the wrapper emits (--log-file, --no-server, --ordered-shutdown, --port, --read-only, --unix-socket, --use-uds, --keep-project) against down, list, project state, attach. Only --keep-project is rejected (unknown flag), on all four; every other wrapped flag is accepted. So removing exactly this one is correct, matching upstream's position in F1bonacc1/process-compose#525. No other references in README/docs.

🟡 Minor

  • Changelog: this is a breaking removal (cli.options.keep-project = true now errors with "option does not exist"), so it belongs under the existing **Breaking changes** bullet rather than as a sibling of #102 under new features. Suggested wording: "Remove cli.options.keep-project: --keep-project is only accepted by process-compose root/up, so the wrapper broke every other subcommand. Pass it directly instead: <wrapper> up --keep-project."

@gabyx

gabyx commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

@srid : Can you retrigger CI maybe. Wondering why its not run automatically?

@srid

srid commented Oct 14, 2026

Copy link
Copy Markdown
Member

Wondering why its not run automatically?

Just fixed it

image

@srid
srid merged commit 8e27bc9 into Platonic-Systems:main Oct 14, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants