Repository navigation
fix: remove 'keep-project' as its not provided on all levels of process-compose - #113
Conversation
|
@srid: Is there a better way to have deprecation? |
|
@gabyx I'd prefer that we just remove it entirely. |
6a30373 to
323b2c7
Compare
323b2c7 to
959f58f
Compare
|
@srid: I removed the flag. |
process-compose
srid
left a comment
There was a problem hiding this comment.
🔴 Blocking: option removed, but its consumer is still there — branch doesn't evaluate
nix/process-compose/cli.nix:157 still reads the deleted option:
++ (lib.optionals o.keep-project [ "--keep-project" ])Reproduced with example/ overriding process-compose-flake to this branch:
error: attribute 'keep-project' missing
at .../nix/process-compose/cli.nix:157:31
Every makeProcessCompose / process-compose.<name> consumer fails; CI build jobs will fail the same way once approved. Deleting that line is the missing part of the diff.
🟢 Scope is right
Ran process-compose v1.122.0 with each flag the wrapper emits (--log-file, --no-server, --ordered-shutdown, --port, --read-only, --unix-socket, --use-uds, --keep-project) against down, list, project state, attach. Only --keep-project is rejected (unknown flag), on all four; every other wrapped flag is accepted. So removing exactly this one is correct, matching upstream's position in F1bonacc1/process-compose#525. No other references in README/docs.
🟡 Minor
- Changelog: this is a breaking removal (
cli.options.keep-project = truenow errors with "option does not exist"), so it belongs under the existing**Breaking changes**bullet rather than as a sibling of#102under new features. Suggested wording: "Removecli.options.keep-project:--keep-projectis only accepted byprocess-composeroot/up, so the wrapper broke every other subcommand. Pass it directly instead:<wrapper> up --keep-project."
|
@srid : Can you retrigger CI maybe. Wondering why its not run automatically? |

Make the top-level flag
keep-projectdeprecated as it should not be set due to: F1bonacc1/process-compose#525 (comment)Its only allowed on
upetc and does not work with most commands. and therefore its better to not having it set into the wrapper.Assited-by: no agent.