apply openssl-1.0.2a-ipv6-apps.patch

[abokth]

apply openssl-1.0.2a-ipv6-apps.patch from git://pkgs.fedoraproject.org/rpms/openssl.git

This adds support for IPv6 in s_client -connect

See also https://bugzilla.redhat.com/198737

[PeterMosmans]

Thanks for the PR. Testing your changes on Windows...

[PeterMosmans]

@abokth , the patch fails on gcc 5.3.0 / MSYS2 / Windows :

s_socket.c: In function 'init_client':
s_socket.c:244:22: error: 'AI_ADDRCONFIG' undeclared (first use in this function)
     hints.ai_flags = AI_ADDRCONFIG;
                      ^
s_socket.c:244:22: note: each undeclared identifier is reported only once for each function it appears in
s_socket.c:248:25: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'WCHAR * {aka short unsigned int *}' [-Wformat=]
         fprintf(stderr, "getaddrinfo: %s\n", gai_strerror(e));
                         ^
s_socket.c:249:18: error: 'EAI_SYSTEM' undeclared (first use in this function)
         if (e == EAI_SYSTEM)
                  ^
s_socket.c: In function 'init_server':
s_socket.c:334:13: warning: overflow in implicit constant conversion [-Woverflow]
     int s = INVALID_SOCKET;
             ^
s_socket.c:349:29: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'WCHAR * {aka short unsigned int *}' [-Wformat=]
             fprintf(stderr, "getaddrinfo: %s\n", gai_strerror(e));
                             ^
s_socket.c:350:22: error: 'EAI_SYSTEM' undeclared (first use in this function)
             if (e == EAI_SYSTEM)
                      ^
s_socket.c: At top level:
s_socket.c:521:24: warning: 'GetHostByName' defined but not used [-Wunused-function]
 static struct hostent *GetHostByName(char *name)
                        ^
s_socket.c:111:12: warning: 'host_ip' declared 'static' but never defined [-Wunused-function]
 static int host_ip(char *str, unsigned char ip[4]);
            ^
<builtin>: recipe for target 's_socket.o' failed
make[1]: *** [s_socket.o] Error 1
make[1]: Leaving directory '/r/public/openssl/apps'
Makefile:294: recipe for target 'build_apps' failed
make: *** [build_apps] Error 1

Could you have a look at that ?

[drwetter]

Hi Peter,

that appears the same patch I gave you before and you created the IPv6 branch which is no more :(

I have that patch on my project site (https://github.com/drwetter/testssl.sh/tree/master/bin) also.

That works under Linux and BSD. Is it an option for you to use if default for other architectures?

Cheers, Dirk

Set from my mobile. Excuse my brevity&typos

[drwetter]

argh... errr sorry. My mobile's auto-correction...

Is it an option for you to use IFDEFs for other architectures?

[PeterMosmans]

Hi @drwetter - Hmm, let me check. It will raise the complexity significantly.
I'll get back to you...