fix(parity): surface Cargo failures before reporting regressions - #10963
proggeramlug wants to merge 2 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe parity harness now checks for Cargo before applicable runs and reports the last 40 lines from failed compiler, runtime, and WebAssembly host builds. A changelog entry documents the behavior. ChangesParity build diagnostics
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Parity runs now report required Cargo failures clearly and expose relevant build diagnostics; the change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on main in merge train 256 (#11018, v0.5.1638), main Carried at head Trains rebase-merge, so commits get new SHAs and GitHub cannot mark this PR merged. Closed as landed. |
Fixes #10920.
Verification:
bash -n run_parity_tests.sh,git diff --check, and targeted mock-Cargo runs covering a failed build and a prebuilt mixed-suite run without Cargo on PATH.Summary by CodeRabbit
Bug Fixes
Documentation