Catch exceptions thrown from setup/teardown#2889
Open
rniczh wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
==========================================
- Coverage 97.01% 97.01% -0.01%
==========================================
Files 167 167
Lines 18830 18826 -4
Branches 1770 1770
==========================================
- Hits 18268 18264 -4
Misses 417 417
Partials 145 145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hello. You may have forgotten to update the changelog!
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
If either function, setup and teardown ,throws a C++ exception like
RT_FAILthe unwinder hits the ctypes C frame, which has no C++ exception handler.libc++abifalls back tostd::terminate()and the interpreter aborts:Description of the Change:
Add two nanobind bindings (
wrapper.invoke_setup/wrapper.invoke_teardown) that call the underlying C function pointers, and route__enter__/__exit__through them.Benefits:
Possible Drawbacks:
Related GitHub Issues:
#2885
[sc-119222]