Skip to content

Update Member: Remove email change support - #99

Merged
Allimonae merged 1 commit into
mainfrom
disable-email
Sep 4, 2026
Merged

Update Member: Remove email change support#99
Allimonae merged 1 commit into
mainfrom
disable-email

Conversation

@Allimonae

@Allimonae Allimonae commented Aug 26, 2026

Copy link
Copy Markdown
Member

Disables email changes in member profile updates until email change verification is implemented. Removed and updated some tests.

What changed?

The email field in the member profile form is now always disabled, with an updated description informing users that email changes are not currently supported. On the backend, updateMember now throws a ValidationException if an email change is attempted. The previously existing duplicate email handling logic (including the DuplicateKeyException catch block and MemberDuplicateException) has been removed from the update flow since it is no longer reachable.

Why make this change?

Email changes require a verification flow (e.g., confirming ownership of the new address) that has not yet been implemented. Disabling this functionality prevents unverified email changes until proper verification support is in place.

Allimonae commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

@Allimonae
Allimonae marked this pull request as ready for review August 26, 2026 23:50
@Allimonae
Allimonae changed the base branch from add-profile-link to graphite-base/99 August 26, 2026 23:51
@graphite-app
graphite-app Bot changed the base branch from graphite-base/99 to main August 26, 2026 23:52
@graphite-app
graphite-app Bot requested a review from a team August 26, 2026 23:52
@graphite-app

graphite-app Bot commented Aug 26, 2026

Copy link
Copy Markdown

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (08/26/26)

2 reviewers were added to this PR based on Henry Chen's automation.

@spiffyy99

Copy link
Copy Markdown

also add a test in for the validation exception being thrown

Comment thread src/test/java/org/patinanetwork/patchats/api/member/MemberServiceTest.java Outdated

Allimonae commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

Merge activity

  • Sep 4, 4:38 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 4, 4:39 PM UTC: Graphite rebased this pull request as part of a merge.
  • Sep 4, 4:41 PM UTC: Graphite couldn't merge this PR because it failed for an unknown reason.
  • Sep 4, 4:41 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 4, 4:42 PM UTC: Graphite couldn't merge this PR because it failed for an unknown reason.
  • Sep 4, 4:48 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 4, 4:48 PM UTC: @Allimonae merged this pull request with Graphite.

@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2026

Copy link
Copy Markdown

@spiffyy99
spiffyy99 self-requested a review September 4, 2026 16:47
@Allimonae
Allimonae merged commit e590306 into main Sep 4, 2026
7 checks passed
@Allimonae
Allimonae deleted the disable-email branch September 4, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants