Skip to content

[DO NOT MERGE] Remove error messages from the event log - #5886

Draft
rbev wants to merge 1 commit into
masterfrom
remove-error-message-eventlog
Draft

rbev wants to merge 1 commit into
masterfrom
remove-error-message-eventlog

Conversation

@rbev

@rbev rbev commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

This pull request removes the event log entry for individual message failures from both the codebase and tests. Instead, failed messages are now only visible on the failed messages screen, not in the event log. This change reduces write and retention overhead on the event log's hot ingest path and simplifies related test logic.

Event log and message failure handling:

  • Updated documentation in docs/eventlog-design.md to clarify that message failures are no longer recorded in the event log, but are instead visible only on the failed messages screen.
  • Removed the MessageFailedDefinition class and its registration, which previously mapped message failure events to event log entries. [1] [2]

Test cleanup and simplification:

  • Removed the test Should_add_an_event_log_item from When_a_message_has_failed.cs, which checked for event log entries related to message failures.
  • Removed code and helper methods from When_hosting_error_ingestion_only.cs that waited for message failure event log entries, as these entries are no longer created. [1] [2]

Do Not Merge

This PR is for v7 and should not be merged to master until it is time to mark that branch for the major update

@johnsimons johnsimons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we can't merge this one yet.

@warwickschroeder warwickschroeder changed the title Remove error messages from the event log [DO NOT MERGE] Remove error messages from the event log Sep 14, 2026
@warwickschroeder

Copy link
Copy Markdown
Contributor

I assume we can't merge this one yet.

Correct. @rbev Maybe make it draft, and an explanation in the description

@rbev
rbev marked this pull request as draft September 15, 2026 01:37
@rbev rbev added this to the NextMajor milestone Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants