Refactor windowed arrays to use a numpy backed DataArray cache - #2846
Open
wyatt-fluidnumerics wants to merge 5 commits into
Open
Refactor windowed arrays to use a numpy backed DataArray cache#2846wyatt-fluidnumerics wants to merge 5 commits into
wyatt-fluidnumerics wants to merge 5 commits into
Conversation
…tead of a dictionary cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This improvement is largely outlined in #2843. The goal is to remove the current codes dependence on a
np.stackcall inWindowedArray.isel()which causes a large in memory copy. This implementation replaces the existing dictionary cache with a numpy backed DataArray, which allows for direct indexing and removes the need to reconstruct a DataArray from the dictionary cache on every call to.isel(). This results in significant performance improvement for large datasets (as much 20x or more depending on size and advection scheme).Additionally, these changes mean that in theory
WindowedArraynow has all the needed functionality to support non-synchronous clocks. In practice however, this is likely not a very practical use case as for large datasets holding even a few time levels in the cache can lead to OOM errors on many machines.Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure