Skip to content

Fix dimension suggestions for dynamically loaded worlds #14399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gabrieljr42 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix dimension suggestions for dynamically loaded worlds #14399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
92b0f29
Fix dimension suggestions for dynamically loaded worlds
Gabrieljr42 Oct 15, 2026
702d40d
Document when dimension suggestion settings take effect
Gabrieljr42 Oct 15, 2026
27b3359
Refresh client world lists through configuration
Gabrieljr42 Oct 16, 2026
77cf97a
Use ask-server suggestions for dynamic dimensions
Gabrieljr42 Oct 20, 2026
03ffeae
Enable server-side dimension suggestions by default
Gabrieljr42 Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions paper-server/patches/sources/net/minecraft/commands/Commands.java.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,19 @@
public static final String COMMAND_PREFIX = "/";
private static final ThreadLocal<@Nullable ExecutionContext<CommandSourceStack>> CURRENT_EXECUTION_CONTEXT = new ThreadLocal<>();
private static final Logger LOGGER = LogUtils.getLogger();
@@ -173,6 +_,12 @@
@Override
public @Nullable Identifier suggestionId(final ArgumentCommandNode<CommandSourceStack, ?> node) {
SuggestionProvider<CommandSourceStack> suggestionProvider = node.getCustomSuggestions();
+ // Paper start - Server-side dimension suggestions
+ if (suggestionProvider == null && node.getType() instanceof net.minecraft.commands.arguments.DimensionArgument
+ && io.papermc.paper.configuration.GlobalConfiguration.get().commands.serverSideDimensionSuggestions) {
+ return SuggestionProviders.getName(SuggestionProviders.ASK_SERVER);
+ }
+ // Paper end - Server-side dimension suggestions
return suggestionProvider != null ? SuggestionProviders.getName(suggestionProvider) : null;
}

@@ -183,6 +_,7 @@

@Override
Expand Down
2 changes: 2 additions & 0 deletions paper-server/src/main/java/io/papermc/paper/configuration/GlobalConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,8 @@ public class UnsupportedSettings extends ConfigurationPart {

public class Commands extends ConfigurationPart {
public boolean suggestPlayerNamesWhenNullTabCompletions = true;
@Comment("Request dimension suggestions from the server to include worlds loaded after the player joined. Players must reconnect or have their commands resent after this setting changes.")
public boolean serverSideDimensionSuggestions = true;
@Comment("Allow mounting entities to a player in the Vanilla '/ride' command.")
public boolean rideCommandAllowPlayerAsVehicle = false;
}
Expand Down
Loading