Fix Adventure Codec for ClickEvent#custom when BinaryTagHolder is null#14075
Merged
electronicboy merged 1 commit intoJul 21, 2026
Merged
Conversation
Doc94
force-pushed
the
fix/14072-click-event-optional-nbt
branch
from
July 17, 2026 03:56
c969199 to
41ae6cc
Compare
kennytv
approved these changes
Jul 18, 2026
papermc-projects
Bot
moved this from Awaiting review
to Full approval
in Paper PR Queue
Warriorrrr
approved these changes
Jul 19, 2026
electronicboy
approved these changes
Jul 21, 2026
github-project-automation
Bot
moved this from Full approval
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #14072
Looks like since Adventure 5 the BinaryTagHolder for ClickEvent#custom can be null causing issues in the Adventure Codec because mark that field like NonNull, this PR just handle that case for use the correct behaviour.