Skip to content

fix: save the observation sent to POST /entry - #59

Merged
PPeitsch merged 1 commit into
mainfrom
fix/entry-observation
Oct 4, 2026
Merged

PPeitsch merged 1 commit into
mainfrom
fix/entry-observation

Conversation

@PPeitsch

@PPeitsch PPeitsch commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Description

POST /entry accepted an observation field but never stored it, although ScheduleEntry has the column (review finding C10). Now:

  • the observation is saved, trimmed, and an empty string clears it;
  • a request without the key keeps the note already saved for the day;
  • GET /entry/<date> returns observation.

The create/update branches are merged into one path, and the unused imports in the module are gone.

Type of Change

  • Bug fix

Testing

  • New test_manual_entry_saves_observation (save, keep when omitted, clear with empty string).
  • pytest (255 passed), black, isort, mypy clean.

Screenshots

Not applicable: JSON endpoint, no UI change.

Checklist

  • I have read the contributing guidelines
  • I have followed the project's code style (Black, isort, PEP 8)
  • My code generates no new warnings

@PPeitsch
PPeitsch merged commit a504fe7 into main Oct 4, 2026
2 checks passed
@PPeitsch
PPeitsch deleted the fix/entry-observation branch October 4, 2026 18:22
@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
app/routes/manual_entry.py 98.27% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PPeitsch PPeitsch mentioned this pull request Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant