Repository navigation
fix: save the observation sent to POST /entry - #59
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
POST /entryaccepted anobservationfield but never stored it, althoughScheduleEntryhas the column (review finding C10). Now:GET /entry/<date>returnsobservation.The create/update branches are merged into one path, and the unused imports in the module are gone.
Type of Change
Testing
test_manual_entry_saves_observation(save, keep when omitted, clear with empty string).pytest(255 passed),black,isort,mypyclean.Screenshots
Not applicable: JSON endpoint, no UI change.
Checklist