[DPO] Drop subprocess inference, add more framework support, doc update#970
Closed
wheresmyhair wants to merge 1 commit into
Closed
[DPO] Drop subprocess inference, add more framework support, doc update#970wheresmyhair wants to merge 1 commit into
wheresmyhair wants to merge 1 commit into
Conversation
- iterative_dpo_aligner: dispatch in-process VLLMInferencer or SGLangInferencer based on inference_engine; fix DataProto -> text_to_textlist conversion left misaligned by #967 (n>1 rollouts are repeat-interleaved by prepare_inputs_for_inference and need to be ungrouped via meta_info["actual_n_rollouts"]). - vllm_inferencer: mark MemorySafeVLLMInferencer deprecated with DeprecationWarning; scheduled for removal in lmflow 1.1.0. - auto_pipeline: relax iterative_dpo_aligner gate from vllm AND trl AND ray to trl AND (vllm OR sglang); ray is only needed for the opt-in distributed reward inference path. - setup.py: bump trl 0.8.0 -> trl>=0.11,<0.12; add pybase64 to [sglang] and rich to [trl] to work around upstream packaging gaps (sglang.utils eagerly imports pybase64; trl 0.11.x lazy-imports rich). - README + 5 localized READMEs: document optional dependency extras and the vllm/sglang environment incompatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Support more inference frameworks when doing DPO, trl version update, and readme update
Detailed Description
iterative_dpo_alignerinference_enginearg;DataProto->text_to_textlistconversion left misaligned by [Data] Apply DataProto to vLLM Inference & Align API with SGLang #967 (n>1 rollouts are repeat-interleaved byprepare_inputs_for_inferenceand need to be ungrouped viameta_info["actual_n_rollouts"]).auto_pipelineiterative_dpo_alignergate fromvllm AND trl AND raytotrl AND (vllm OR sglang);setup.pypybase64to [sglang] andrichto [trl] to work around upstream packaging gaps (sglang.utils eagerly imports pybase64; trl 0.11.x lazy-imports rich).README+ 5 localizedREADMEs