feat: add an empirical turbine model - #83
Merged
Merged
Conversation
dietmarw
force-pushed
the
feat/empiricalTurbine
branch
from
March 3, 2026 15:03
1425890 to
cf83711
Compare
Collaborator
|
@boerrebj I've run the test models with Dymola and got non-linear system warnings/errors but Dymola manages to complete the simulation. The diagnostics are slightly different when running Dymola 2020 to Dymola 2026x , So I'm including both here in case something rings a bell: |
dietmarw
marked this pull request as draft
March 3, 2026 17:10
boerrebj
marked this pull request as ready for review
April 21, 2026 12:27
Collaborator
Author
|
Should be ready for review and merge with main trunk. |
dietmarw
previously requested changes
Jul 17, 2026
Collaborator
There was a problem hiding this comment.
I've added a couple of commits for cleanup purposes. After that, there are a couple of things like to discuss before merging:
OpenHPLTest.TorqueEquation: This package contains (I think) meaningless tests. The models themselves are already used by the other base classes and are used in real examples. So I guess we can safely remove that package. So you agree?- EmpiricalTurbine:
- The model contains an unused constant
eps, remove? - The constants alpha and beta have no description and no type so it would be hard to know what they stand for.
- (already fixed) uncecessarily assignment of rho, just use data.rho directly, same with g
- The model contains an unused constant
OpenHPLTest.Empirical:- I've simplified the Test 04 and 05 models to extend from the sam 01 model like the others. This is when I noticed that 04 and 05 are actually identical. So should we remove that?
- I've also simplified Test06 and 07 with help of extension.
Collaborator
Author
|
I agree with the proposals. In the future I will try to be better to distinguish between my internal development testing and checked in tests to include in the the distribution. |
…normalization of speed (to p.u.) in Power2Torque and TorqueEquation. Added test case for TorqueEquation in OpenHPLTest
… the pipe + turbine model.
dietmarw-se
force-pushed
the
feat/empiricalTurbine
branch
from
August 13, 2026 11:24
38b7e14 to
4f23ade
Compare
The TorqueEquation is already used in the examples.
dietmarw-se
force-pushed
the
feat/empiricalTurbine
branch
from
August 13, 2026 11:32
82665fe to
1057c1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turbine model based on emprirical relations for reaction turbines (includes throtling effect).