Repository navigation
Fix UI freeze during driverless PPD validation - #480
Draft
SinghCod3r wants to merge 2 commits into
Draft
SinghCod3r wants to merge 2 commits into
SinghCod3r wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Driverless PPD validation can block the GTK main loop while
getServerPPD()performs a CUPS IPP request. This causes the s-c-p UI to freeze temporarily while searching for drivers.This change moves driverless PPD validation off the GTK main thread and resumes the printer-installation flow when validation completes.
Changes
INSTALL_RESULT_OPS_PENDINGwhile asynchronous validation is in progress.test_newprinter.pyto model the asynchronous validation/completion flow without globally monkeypatching production methods.Testing
Focused tests:
Full test suite:
The remaining failure is in
test_ppds.pyand is caused by the local CUPS/PPD catalog mismatch for the Epson Stylus D78 and Canon iP3000. This failure is pre-existing and is unrelated to these changes.Also verified:
git diff --checkpasses.Forwardclick after asynchronous driverless validation completes.Applybutton when returning to the driver-selection page.Supersedes #479
This PR contains the same implementation previously submitted in #479. The previous PR was closed after its source branch was deleted. The implementation itself has been preserved and is now submitted from fix/driverless-ppd-validation-async.