Repository navigation
Send lowercase attributes-natural-language (fixes #140) - #141
Merged
alexpevzner merged 1 commit intoOct 9, 2026
Merged
Conversation
RFC 8011 section 5.1.9 requires lowercase naturalLanguage values in IPP. PAPPL >= 1.4.12 rejects "en-US" with client-error-bad-request, so the init Get-Printer-Attributes request failed and ipp-usb never bridged those printers. Fixes OpenPrinting#140. Assisted-by: Claude:claude-opus-5-5 Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Merged, thanks for reporting that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140.
RFC 8011 §5.1.9 requires lowercase
naturalLanguagevalues in IPP. PAPPL ≥ 1.4.12 enforces this and rejects ipp-usb's init Get-Printer-Attributes request (attributes-natural-language = en-US) withclient-error-bad-request, so ipp-usb never bridges those printers.This changes the value to
en-us. Tested with 0.9.23 plus this change on a Rollo X1040 (firmware 1.6.66 / PAPPL 1.4.12): init completes and a job printed through the bridge. Details and logs are in #140.Assisted-by: Claude:claude-opus-5-5 Claude Code