Skip to content

(G004) remove deprecated ModelicaSystem rewrite_set_functions() - #452

Open
syntron wants to merge 4 commits into
OpenModelica:masterfrom
syntron:G004-remove_deprecated-ModelicaSystem_rewrite_set_functions2
Open

(G004) remove deprecated ModelicaSystem rewrite_set_functions()#452
syntron wants to merge 4 commits into
OpenModelica:masterfrom
syntron:G004-remove_deprecated-ModelicaSystem_rewrite_set_functions2

Conversation

@syntron

@syntron syntron commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

[ModelicaSystemABC] remove code for (depreciated) arguments in set*() methods

  • define code in the compatibility layer in class ModelicaSystem
    [test_ModelicaSystem(OMC)] update tests
  • for new version: remove usage of old definition
  • for compatibility version: test old definition

@syntron
syntron force-pushed the G004-remove_deprecated-ModelicaSystem_rewrite_set_functions2 branch from a9206d3 to e2f18f2 Compare May 11, 2026 18:53
@syntron
syntron force-pushed the G004-remove_deprecated-ModelicaSystem_rewrite_set_functions2 branch 2 times, most recently from 17e049e to 2b5c2db Compare June 30, 2026 19:50
@syntron
syntron force-pushed the G004-remove_deprecated-ModelicaSystem_rewrite_set_functions2 branch 2 times, most recently from 3b50a9b to 8610abe Compare August 11, 2026 19:25
[ModelExecutionException] catch exception if ModelExecutionCmd.run() is used

[bugfix] [ModelicaSystem] fix exception; use ModelicaSystemError (instead of wrong ModelExecutionException)

[bugfix] [ModelicaSystemABC] fix _prepare_input_data() - ensure returned data is dict[str, str]
[compatibility] add class wrapper to provide the depreciation message

[ModelicaSystem] fix / improve wrapper functions for v4.0.0 compatibility

[ModelicaSystemABC] additional checks for setInputs()

[test_ModelicaSystemOMC] add tests for setInputs()

[__init__] define ModelicaSystemDoE at the right point (=> compatibility layer)

[__init__] remove duplicate 'OMCSessionABC' in __all__
[ModelicaSystemABC] remove code for (depreciated) arguments in set*() methods

* define code in the compatibility layer in class ModelicaSystem

[test_ModelicaSystem(OMC)] update tests

* for new version: remove usage of old definition
* for compatibility version: test old definition
@syntron
syntron force-pushed the G004-remove_deprecated-ModelicaSystem_rewrite_set_functions2 branch from 8610abe to e72bfee Compare August 14, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant