Skip to content

CI: move macOS jobs to macos-15 - #111

Merged
keyldev merged 1 commit into
mainfrom
fix/ci-macos-15
Nov 7, 2026
Merged

keyldev merged 1 commit into
mainfrom
fix/ci-macos-15

Conversation

@keyldev

@keyldev keyldev commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator
  • macos-14 runner image is retired; the osx-arm64 job no longer starts and blocks the release

  • same runner for the (disabled) iOS job

Summary

Related

Type

  • Bug fix
  • Feature
  • Refactor / cleanup
  • Docs / CI
  • Other:

Checklist

  • Builds with 0 warnings (TreatWarningsAsErrors=true).
  • Tests pass (dotnet test); new Core logic has unit tests.
  • No layering violation — App references Core only (Infrastructure / Video / Devices wired via DI in a head).
  • Scope stays within one phase (didn't pull work from a later phase's "Не входит").
  • README / docs updated if public commands, options, or setup changed.

Platforms tested

  • Windows
  • Linux
  • macOS
  • Android
  • iOS
  • CI build only

Screenshots / notes

- macos-14 runner image is retired; the osx-arm64 job no longer starts and blocks the release

- same runner for the (disabled) iOS job
@keyldev
keyldev merged commit 078b7eb into main Nov 7, 2026
5 checks passed
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Move macOS CI jobs to macos-15

🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Move the osx-arm64 build to macos-15 so the retired runner no longer blocks releases.
• Set the disabled iOS job to macos-15 for consistency; it remains disabled.
Diagram

graph TD
  A["Desktop build matrix"] --> B["macos-15 runner"] --> C["osx-arm64 artifact"] --> D["Release job"]
  E["Disabled iOS job"] -. "configured only" .-> B
Loading
High-Level Assessment

Changing the two runner labels is the smallest appropriate fix. The existing build and release flow needs no restructuring, and the iOS job remains disabled for its separate Xcode compatibility issue.

Files changed (1) +2 / -2

Other (1) +2 / -2
build.ymlSelect macos-15 for both macOS CI jobs +2/-2

Select macos-15 for both macOS CI jobs

• Changes the osx-arm64 desktop matrix entry from macos-14 to macos-15 so it can start on a supported runner. Changes the disabled iOS job's runner label to match without enabling that job.

.github/workflows/build.yml

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Grey Divider


Informational

1. Disabled iOS job moved to an unverified runner 🐞 Bug ⚙ Maintainability
Description
The ios job's runs-on is changed from macos-14 to macos-15, but the job is hard-disabled
with if: false, and the comment above it still says the GitHub macOS runners do not ship the Xcode
26.5 that the iOS workload needs. The change has no effect on any run today and was not checked
against that Xcode requirement, so whoever re-enables the job may assume macos-15 was verified
when it was not.
Code

.github/workflows/build.yml[273]

+    runs-on: macos-15
Evidence
The job is disabled and its own comment says the required runner image is not yet available, so the
new runner label is untested and the comment no longer matches the change.

.github/workflows/build.yml[272-281]
.github/workflows/build.yml[319-322]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The disabled `ios` job was switched to `macos-15`, but its comment says the runner images do not ship the Xcode 26.5 the iOS workload needs, so the label change is unverified and the comment is now misleading.

## Fix Focus Areas
- .github/workflows/build.yml[272-281]

## Recommended Fix
Either revert the `ios` job's `runs-on` to `macos-14` so the disabled job is left untouched, or keep `macos-15` and amend the comment to state which runner image and Xcode version were checked. Leave `if: false` in place.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
❌ Tickets: failed to load — Ticket collection could not establish complete evidence
Review mode: Auto: 🚀 Fast: Two-line CI runner label bump, single concern, no logic or security impact.

Grey Divider

Tip of the day
💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant